From 4b4c0d8e6920af918f89cd24bab77b82b429c4db Mon Sep 17 00:00:00 2001 From: codex-bot Date: Tue, 21 Oct 2025 14:29:31 -0300 Subject: [PATCH] fix(reports): gate report queries behind staff check; prevent non-staff crashes; trigger Convex deploy by touching convex/reports.ts --- convex/reports.ts | 1 + src/components/reports/backlog-report.tsx | 7 ++++--- src/components/reports/csat-report.tsx | 7 ++++--- src/components/reports/hours-report.tsx | 7 ++++--- src/components/reports/sla-report.tsx | 13 +++++++------ 5 files changed, 20 insertions(+), 15 deletions(-) diff --git a/convex/reports.ts b/convex/reports.ts index c380d22..428cd11 100644 --- a/convex/reports.ts +++ b/convex/reports.ts @@ -330,6 +330,7 @@ export const backlogOverview = query({ }, }); +// Touch to ensure CI convex_deploy runs and that agentProductivity is deployed export const agentProductivity = query({ args: { tenantId: v.string(), viewerId: v.id("users"), range: v.optional(v.string()), companyId: v.optional(v.id("companies")) }, handler: async (ctx, { tenantId, viewerId, range, companyId }) => { diff --git a/src/components/reports/backlog-report.tsx b/src/components/reports/backlog-report.tsx index dfb61c3..9da9ff1 100644 --- a/src/components/reports/backlog-report.tsx +++ b/src/components/reports/backlog-report.tsx @@ -34,13 +34,14 @@ const STATUS_LABELS: Record = { export function BacklogReport() { const [timeRange, setTimeRange] = useState("90d") const [companyId, setCompanyId] = usePersistentCompanyFilter("all") - const { session, convexUserId } = useAuth() + const { session, convexUserId, isStaff } = useAuth() const tenantId = session?.user.tenantId ?? DEFAULT_TENANT_ID + const enabled = Boolean(isStaff && convexUserId) const data = useQuery( api.reports.backlogOverview, - convexUserId ? { tenantId, viewerId: convexUserId as Id<"users">, range: timeRange, companyId: companyId === "all" ? undefined : (companyId as Id<"companies">) } : "skip" + enabled ? { tenantId, viewerId: convexUserId as Id<"users">, range: timeRange, companyId: companyId === "all" ? undefined : (companyId as Id<"companies">) } : "skip" ) - const companies = useQuery(api.companies.list, convexUserId ? { tenantId, viewerId: convexUserId as Id<"users"> } : "skip") as Array<{ id: Id<"companies">; name: string }> | undefined + const companies = useQuery(api.companies.list, enabled ? { tenantId, viewerId: convexUserId as Id<"users"> } : "skip") as Array<{ id: Id<"companies">; name: string }> | undefined const mostCriticalPriority = useMemo(() => { if (!data) return null diff --git a/src/components/reports/csat-report.tsx b/src/components/reports/csat-report.tsx index a4ce42b..2963e97 100644 --- a/src/components/reports/csat-report.tsx +++ b/src/components/reports/csat-report.tsx @@ -25,15 +25,16 @@ function formatScore(value: number | null) { export function CsatReport() { const [companyId, setCompanyId] = usePersistentCompanyFilter("all") const [timeRange, setTimeRange] = useState("90d") - const { session, convexUserId } = useAuth() + const { session, convexUserId, isStaff } = useAuth() const tenantId = session?.user.tenantId ?? DEFAULT_TENANT_ID + const enabled = Boolean(isStaff && convexUserId) const data = useQuery( api.reports.csatOverview, - convexUserId + enabled ? ({ tenantId, viewerId: convexUserId as Id<"users">, range: timeRange, companyId: companyId === "all" ? undefined : (companyId as Id<"companies">) }) : "skip" ) - const companies = useQuery(api.companies.list, convexUserId ? { tenantId, viewerId: convexUserId as Id<"users"> } : "skip") as Array<{ id: Id<"companies">; name: string }> | undefined + const companies = useQuery(api.companies.list, enabled ? { tenantId, viewerId: convexUserId as Id<"users"> } : "skip") as Array<{ id: Id<"companies">; name: string }> | undefined if (!data) { return ( diff --git a/src/components/reports/hours-report.tsx b/src/components/reports/hours-report.tsx index 9540d54..73883f9 100644 --- a/src/components/reports/hours-report.tsx +++ b/src/components/reports/hours-report.tsx @@ -32,15 +32,16 @@ export function HoursReport() { const [timeRange, setTimeRange] = useState("90d") const [query, setQuery] = useState("") const [companyId, setCompanyId] = usePersistentCompanyFilter("all") - const { session, convexUserId } = useAuth() + const { session, convexUserId, isStaff } = useAuth() const tenantId = session?.user.tenantId ?? DEFAULT_TENANT_ID + const enabled = Boolean(isStaff && convexUserId) const data = useQuery( api.reports.hoursByClient, - convexUserId ? { tenantId, viewerId: convexUserId as Id<"users">, range: timeRange } : "skip" + enabled ? { tenantId, viewerId: convexUserId as Id<"users">, range: timeRange } : "skip" ) as { rangeDays: number; items: HoursItem[] } | undefined - const companies = useQuery(api.companies.list, convexUserId ? { tenantId, viewerId: convexUserId as Id<"users"> } : "skip") as Array<{ id: Id<"companies">; name: string }> | undefined + const companies = useQuery(api.companies.list, enabled ? { tenantId, viewerId: convexUserId as Id<"users"> } : "skip") as Array<{ id: Id<"companies">; name: string }> | undefined const filtered = useMemo(() => { const items = data?.items ?? [] const q = query.trim().toLowerCase() diff --git a/src/components/reports/sla-report.tsx b/src/components/reports/sla-report.tsx index 0bad3c9..f6d333c 100644 --- a/src/components/reports/sla-report.tsx +++ b/src/components/reports/sla-report.tsx @@ -30,35 +30,36 @@ function formatMinutes(value: number | null) { export function SlaReport() { const [companyId, setCompanyId] = usePersistentCompanyFilter("all") const [timeRange, setTimeRange] = useState("90d") - const { session, convexUserId } = useAuth() + const { session, convexUserId, isStaff } = useAuth() const tenantId = session?.user.tenantId ?? DEFAULT_TENANT_ID + const enabled = Boolean(isStaff && convexUserId) const data = useQuery( api.reports.slaOverview, - convexUserId + enabled ? ({ tenantId, viewerId: convexUserId as Id<"users">, range: timeRange, companyId: companyId === "all" ? undefined : (companyId as Id<"companies">) }) : "skip" ) const agents = useQuery( api.reports.agentProductivity, - convexUserId + enabled ? ({ tenantId, viewerId: convexUserId as Id<"users">, range: timeRange, companyId: companyId === "all" ? undefined : (companyId as Id<"companies">) }) : "skip" ) as { rangeDays: number; items: Array<{ agentId: string; name: string | null; email: string | null; open: number; resolved: number; avgFirstResponseMinutes: number | null; avgResolutionMinutes: number | null; workedHours: number }> } | undefined const openedResolved = useQuery( api.reports.openedResolvedByDay, - convexUserId + enabled ? ({ tenantId, viewerId: convexUserId as Id<"users">, range: timeRange, companyId: companyId === "all" ? undefined : (companyId as Id<"companies">) }) : "skip" ) as { rangeDays: number; series: Array<{ date: string; opened: number; resolved: number }> } | undefined const channelsSeries = useQuery( api.reports.ticketsByChannel, - convexUserId + enabled ? ({ tenantId, viewerId: convexUserId as Id<"users">, range: timeRange, companyId: companyId === "all" ? undefined : (companyId as Id<"companies">) }) : "skip" ) as { rangeDays: number; channels: string[]; points: Array<{ date: string; values: Record }> } | undefined - const companies = useQuery(api.companies.list, convexUserId ? { tenantId, viewerId: convexUserId as Id<"users"> } : "skip") as Array<{ id: Id<"companies">; name: string }> | undefined + const companies = useQuery(api.companies.list, enabled ? { tenantId, viewerId: convexUserId as Id<"users"> } : "skip") as Array<{ id: Id<"companies">; name: string }> | undefined const queueTotal = useMemo( () => data?.queueBreakdown.reduce((acc: number, queue: { open: number }) => acc + queue.open, 0) ?? 0,