refactor: quality workflow, docs, tests

src/app/login/login-page-client.tsx

@@ -21,23 +21,30 @@ export function LoginPageClient() {
   const { data: session, isPending } = useSession()
   const callbackUrl = searchParams?.get("callbackUrl") ?? undefined
   const [isHydrated, setIsHydrated] = useState(false)
+  const sessionUser = session?.user
+  const userId = sessionUser?.id ?? null
+  const normalizedRole = sessionUser?.role ? sessionUser.role.toLowerCase() : null
+  const persona = typeof sessionUser?.machinePersona === "string" ? sessionUser.machinePersona.toLowerCase() : null
 
   useEffect(() => {
     if (isPending) return
-    if (!session?.user) return
-    const role = (session.user.role ?? "").toLowerCase()
-    const persona = (session.user as any).machinePersona
-      ? String((session.user as any).machinePersona).toLowerCase()
-      : null
+    if (!userId) return
     const defaultDest =
-      role === "machine"
+      normalizedRole === "machine"
         ? persona === "manager"
           ? "/dashboard"
           : "/portal/tickets"
         : "/dashboard"
     const destination = callbackUrl ?? defaultDest
     router.replace(destination)
-  }, [callbackUrl, isPending, router, session?.user])
+  }, [
+    callbackUrl,
+    isPending,
+    normalizedRole,
+    persona,
+    router,
+    userId,
+  ])
 
   useEffect(() => {
     setIsHydrated(true)