fix(web): gate staff-only Convex queries to avoid RBAC errors on dashboard and tickets; docs: add desktop agent history and troubleshooting

This commit is contained in:
Esdras Renan 2025-10-10 01:11:03 -03:00
parent 7685370c05
commit ab820ddeca
11 changed files with 144 additions and 33 deletions

View file

@ -48,7 +48,7 @@ export function ChartAreaInteractive() {
// Persistir seleção de empresa globalmente
const [companyId, setCompanyId] = usePersistentCompanyFilter("all")
const [companyQuery, setCompanyQuery] = React.useState("")
const { session, convexUserId } = useAuth()
const { session, convexUserId, isStaff } = useAuth()
const tenantId = session?.user.tenantId ?? DEFAULT_TENANT_ID
React.useEffect(() => {
@ -61,13 +61,14 @@ export function ChartAreaInteractive() {
}
}, [isMobile])
const reportsEnabled = Boolean(isStaff && convexUserId)
const report = useQuery(
api.reports.ticketsByChannel,
convexUserId
reportsEnabled
? ({ tenantId, viewerId: convexUserId as Id<"users">, range: timeRange, companyId: companyId === "all" ? undefined : (companyId as Id<"companies">) })
: "skip"
)
const companies = useQuery(api.companies.list, convexUserId ? { tenantId, viewerId: convexUserId as Id<"users"> } : "skip") as Array<{ id: Id<"companies">; name: string }> | undefined
const companies = useQuery(api.companies.list, reportsEnabled ? { tenantId, viewerId: convexUserId as Id<"users"> } : "skip") as Array<{ id: Id<"companies">; name: string }> | undefined
const filteredCompanies = React.useMemo(() => {
const q = companyQuery.trim().toLowerCase()
if (!q) return companies ?? []

View file

@ -25,12 +25,13 @@ const chartConfig = {
export function ChartOpenedResolved() {
const [timeRange, setTimeRange] = React.useState("30d")
const [companyId, setCompanyId] = usePersistentCompanyFilter("all")
const { session, convexUserId } = useAuth()
const { session, convexUserId, isStaff } = useAuth()
const tenantId = session?.user.tenantId ?? DEFAULT_TENANT_ID
const reportsEnabled = Boolean(isStaff && convexUserId)
const data = useQuery(
api.reports.openedResolvedByDay,
convexUserId
reportsEnabled
? ({
tenantId,
viewerId: convexUserId as Id<"users">,
@ -40,7 +41,10 @@ export function ChartOpenedResolved() {
: "skip"
) as { rangeDays: number; series: SeriesPoint[] } | undefined
const companies = useQuery(api.companies.list, convexUserId ? { tenantId, viewerId: convexUserId as Id<"users"> } : "skip") as Array<{ id: Id<"companies">; name: string }> | undefined
const companies = useQuery(
api.companies.list,
reportsEnabled ? { tenantId, viewerId: convexUserId as Id<"users"> } : "skip"
) as Array<{ id: Id<"companies">; name: string }> | undefined
if (!data) {
return <Skeleton className="h-[300px] w-full" />
@ -109,4 +113,3 @@ export function ChartOpenedResolved() {
</Card>
)
}

View file

@ -26,15 +26,15 @@ export function ViewsCharts() {
function BacklogPriorityPie() {
const [companyId, setCompanyId] = usePersistentCompanyFilter("all")
const [timeRange, setTimeRange] = React.useState("30d")
const { session, convexUserId } = useAuth()
const { session, convexUserId, isStaff } = useAuth()
const tenantId = session?.user.tenantId ?? DEFAULT_TENANT_ID
const data = useQuery(
api.reports.backlogOverview,
convexUserId
isStaff && convexUserId
? ({ tenantId, viewerId: convexUserId as Id<"users">, range: timeRange, companyId: companyId === "all" ? undefined : (companyId as Id<"companies">) })
: "skip"
) as { priorityCounts: Record<string, number> } | undefined
const companies = useQuery(api.companies.list, convexUserId ? { tenantId, viewerId: convexUserId as Id<"users"> } : "skip") as Array<{ id: Id<"companies">; name: string }> | undefined
const companies = useQuery(api.companies.list, isStaff && convexUserId ? { tenantId, viewerId: convexUserId as Id<"users"> } : "skip") as Array<{ id: Id<"companies">; name: string }> | undefined
if (!data) return <Skeleton className="h-[300px] w-full" />
const PRIORITY_LABELS: Record<string, string> = { LOW: "Baixa", MEDIUM: "Média", HIGH: "Alta", URGENT: "Crítica" }
@ -106,15 +106,15 @@ function BacklogPriorityPie() {
function QueuesOpenBar() {
const [companyId, setCompanyId] = usePersistentCompanyFilter("all")
const { session, convexUserId } = useAuth()
const { session, convexUserId, isStaff } = useAuth()
const tenantId = session?.user.tenantId ?? DEFAULT_TENANT_ID
const data = useQuery(
api.reports.slaOverview,
convexUserId
isStaff && convexUserId
? ({ tenantId, viewerId: convexUserId as Id<"users">, companyId: companyId === "all" ? undefined : (companyId as Id<"companies">) })
: "skip"
) as { queueBreakdown: { id: string; name: string; open: number }[] } | undefined
const companies = useQuery(api.companies.list, convexUserId ? { tenantId, viewerId: convexUserId as Id<"users"> } : "skip") as Array<{ id: Id<"companies">; name: string }> | undefined
const companies = useQuery(api.companies.list, isStaff && convexUserId ? { tenantId, viewerId: convexUserId as Id<"users"> } : "skip") as Array<{ id: Id<"companies">; name: string }> | undefined
if (!data) return <Skeleton className="h-[300px] w-full" />
const chartData = (data.queueBreakdown ?? []).map((q) => ({ queue: q.name, open: q.open }))

View file

@ -33,12 +33,13 @@ function formatScore(value: number | null) {
}
export function SectionCards() {
const { session, convexUserId } = useAuth()
const { session, convexUserId, isStaff } = useAuth()
const tenantId = session?.user.tenantId ?? DEFAULT_TENANT_ID
const dashboardEnabled = Boolean(isStaff && convexUserId)
const dashboard = useQuery(
api.reports.dashboardOverview,
convexUserId ? { tenantId, viewerId: convexUserId as Id<"users"> } : "skip"
dashboardEnabled ? { tenantId, viewerId: convexUserId as Id<"users"> } : "skip"
)
const trendInfo = useMemo(() => {

View file

@ -56,14 +56,15 @@ export function NewTicketDialog() {
},
mode: "onTouched",
})
const { convexUserId } = useAuth()
const queueArgs = convexUserId
const { convexUserId, isStaff } = useAuth()
const queuesEnabled = Boolean(isStaff && convexUserId)
const queueArgs = queuesEnabled
? { tenantId: DEFAULT_TENANT_ID, viewerId: convexUserId as Id<"users"> }
: "skip"
useDefaultQueues(DEFAULT_TENANT_ID)
const queuesRaw = useQuery(
convexUserId ? api.queues.summary : "skip",
queuesEnabled ? api.queues.summary : "skip",
queueArgs
) as TicketQueueSummary[] | undefined
const queues = useMemo(() => queuesRaw ?? [], [queuesRaw])

View file

@ -30,12 +30,13 @@ const secondaryButtonClass = "inline-flex items-center gap-2 rounded-lg border b
export function PlayNextTicketCard({ context }: PlayNextTicketCardProps) {
const router = useRouter()
const { convexUserId } = useAuth()
const queueArgs = convexUserId
const { convexUserId, isStaff } = useAuth()
const queuesEnabled = Boolean(isStaff && convexUserId)
const queueArgs = queuesEnabled
? { tenantId: DEFAULT_TENANT_ID, viewerId: convexUserId as Id<"users"> }
: "skip"
const queueSummary = (
useQuery(convexUserId ? api.queues.summary : "skip", queueArgs) as TicketQueueSummary[] | undefined
useQuery(queuesEnabled ? api.queues.summary : "skip", queueArgs) as TicketQueueSummary[] | undefined
) ?? []
const playNext = useMutation(api.tickets.playNext)
const [selectedQueueId, setSelectedQueueId] = useState<string | undefined>(undefined)

View file

@ -14,11 +14,12 @@ interface TicketQueueSummaryProps {
}
export function TicketQueueSummaryCards({ queues }: TicketQueueSummaryProps) {
const { convexUserId } = useAuth()
const queueArgs = convexUserId
const { convexUserId, isStaff } = useAuth()
const enabled = Boolean(isStaff && convexUserId)
const queueArgs = enabled
? { tenantId: DEFAULT_TENANT_ID, viewerId: convexUserId as Id<"users"> }
: "skip"
const fromServer = useQuery(convexUserId ? api.queues.summary : "skip", queueArgs)
const fromServer = useQuery(enabled ? api.queues.summary : "skip", queueArgs)
const data: TicketQueueSummary[] = (queues ?? (fromServer as TicketQueueSummary[] | undefined) ?? [])
if (!queues && fromServer === undefined) {

View file

@ -88,7 +88,7 @@ function formatDuration(durationMs: number) {
}
export function TicketSummaryHeader({ ticket }: TicketHeaderProps) {
const { convexUserId, role } = useAuth()
const { convexUserId, role, isStaff } = useAuth()
const isManager = role === "manager"
useDefaultQueues(ticket.tenantId)
const changeAssignee = useMutation(api.tickets.changeAssignee)
@ -99,11 +99,12 @@ export function TicketSummaryHeader({ ticket }: TicketHeaderProps) {
const pauseWork = useMutation(api.tickets.pauseWork)
const updateCategories = useMutation(api.tickets.updateCategories)
const agents = (useQuery(api.users.listAgents, { tenantId: ticket.tenantId }) as Doc<"users">[] | undefined) ?? []
const queueArgs = convexUserId
const queuesEnabled = Boolean(isStaff && convexUserId)
const queueArgs = queuesEnabled
? { tenantId: ticket.tenantId, viewerId: convexUserId as Id<"users"> }
: "skip"
const queues = (
useQuery(convexUserId ? api.queues.summary : "skip", queueArgs) as TicketQueueSummary[] | undefined
useQuery(queuesEnabled ? api.queues.summary : "skip", queueArgs) as TicketQueueSummary[] | undefined
) ?? []
const { categories, isLoading: categoriesLoading } = useTicketCategories(ticket.tenantId)
const [status] = useState<TicketStatus>(ticket.status)

View file

@ -14,14 +14,15 @@ import { useDefaultQueues } from "@/hooks/use-default-queues"
export function TicketsView() {
const [filters, setFilters] = useState<TicketFiltersState>(defaultTicketFilters)
const { session, convexUserId } = useAuth()
const { session, convexUserId, isStaff } = useAuth()
const tenantId = session?.user.tenantId ?? DEFAULT_TENANT_ID
useDefaultQueues(tenantId)
const queuesEnabled = Boolean(isStaff && convexUserId)
const queues = useQuery(
convexUserId ? api.queues.summary : "skip",
convexUserId ? { tenantId, viewerId: convexUserId as Id<"users"> } : "skip"
queuesEnabled ? api.queues.summary : "skip",
queuesEnabled ? { tenantId, viewerId: convexUserId as Id<"users"> } : "skip"
) as TicketQueueSummary[] | undefined
const ticketsRaw = useQuery(
api.tickets.list,