From b916ce3083e843c46a74baec1bf81cb1e57e3f90 Mon Sep 17 00:00:00 2001
From: Seu Nome <seu-email@exemplo.com>
Date: Mon, 8 Dec 2025 15:29:53 -0300
Subject: [PATCH] fix: remove docker service update redundante que causava
 downtime
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

O step "Ensure Convex service envs" fazia docker service update
para adicionar env vars que já são passadas pelo stack.yml via
substituição de variáveis. Isso disparava um rolling update
desnecessário com ~60s de downtime a cada deploy.

As env vars (MACHINE_PROVISIONING_SECRET, etc) já são definidas
no stack.yml e interpoladas do .env durante o docker stack deploy.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
---
 .github/workflows/ci-cd-web-desktop.yml | 28 +++----------------------
 1 file changed, 3 insertions(+), 25 deletions(-)

diff --git a/.github/workflows/ci-cd-web-desktop.yml b/.github/workflows/ci-cd-web-desktop.yml
index 208661e..886d0b9 100644
--- a/.github/workflows/ci-cd-web-desktop.yml
+++ b/.github/workflows/ci-cd-web-desktop.yml
@@ -296,31 +296,9 @@ jobs:
           echo "Using APP_DIR (stable)=$APP_DIR_STABLE"
           APP_DIR="$APP_DIR_STABLE" RELEASE_SHA=${{ github.sha }} docker stack deploy --with-registry-auth -c stack.yml sistema
 
-      - name: Ensure Convex service envs (sem force restart)
-        run: |
-          cd "$EFFECTIVE_APP_DIR"
-          set -o allexport
-          if [ -f .env ]; then . ./.env; fi
-          set +o allexport
-          echo "Ensuring Convex envs on service: sistema_convex_backend"
-          # Acumula todas as env vars em um único update para evitar múltiplos restarts
-          UPDATE_ARGS=""
-          if [ -n "${MACHINE_PROVISIONING_SECRET:-}" ]; then
-            UPDATE_ARGS="$UPDATE_ARGS --env-add MACHINE_PROVISIONING_SECRET=${MACHINE_PROVISIONING_SECRET}"
-          fi
-          if [ -n "${MACHINE_TOKEN_TTL_MS:-}" ]; then
-            UPDATE_ARGS="$UPDATE_ARGS --env-add MACHINE_TOKEN_TTL_MS=${MACHINE_TOKEN_TTL_MS}"
-          fi
-          if [ -n "${FLEET_SYNC_SECRET:-}" ]; then
-            UPDATE_ARGS="$UPDATE_ARGS --env-add FLEET_SYNC_SECRET=${FLEET_SYNC_SECRET}"
-          fi
-          if [ -n "$UPDATE_ARGS" ]; then
-            echo "Applying env updates (will respect update_config.order: start-first)..."
-            docker service update $UPDATE_ARGS sistema_convex_backend || true
-          fi
-          echo "Current envs:"
-          docker service inspect sistema_convex_backend --format '{{range .Spec.TaskTemplate.ContainerSpec.Env}}{{println .}}{{end}}' || true
-          # NÃO fazemos --force aqui para respeitar a estratégia start-first do stack.yml
+      # Removido: "Ensure Convex service envs" - as env vars já são passadas pelo stack.yml
+      # via substituição de variáveis do .env. Fazer docker service update aqui causava
+      # um rolling update adicional desnecessário com ~60s de downtime.
 
       - name: Smoke test — register + heartbeat
         run: |