esdras/sistema-de-chamados
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Allow managers to comment without assignee; keep assignee requirement for admin/agent; reflect in UI

Browse source
This commit is contained in:
Esdras Renan 2025-10-19 02:45:53 -03:00
parent b468c6c9e7
commit 7c025a0398
2 changed files with 7 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

5
convex/tickets.ts
View file

@ -781,9 +781,10 @@ export const addComment = mutation({
// Regra: a equipe (ADMIN/AGENT/MANAGER) só pode comentar se o ticket tiver responsável. // Regra: a equipe (ADMIN/AGENT/MANAGER) só pode comentar se o ticket tiver responsável.
// O solicitante (colaborador) pode comentar sempre. // O solicitante (colaborador) pode comentar sempre.
const isRequester = String(ticketDoc.requesterId) === String(author._id) const isRequester = String(ticketDoc.requesterId) === String(author._id)
const isStaff = normalizedRole === "ADMIN" || normalizedRole === "AGENT" || normalizedRole === "MANAGER" const isAdminOrAgent = normalizedRole === "ADMIN" || normalizedRole === "AGENT"
const hasAssignee = Boolean(ticketDoc.assigneeId) const hasAssignee = Boolean(ticketDoc.assigneeId)
if (!isRequester && isStaff && !hasAssignee) { // Gestores podem comentar mesmo sem responsável; admin/agent só com responsável
if (!isRequester && isAdminOrAgent && !hasAssignee) {
throw new ConvexError("Somente é possível comentar quando o chamado possui um responsável.") throw new ConvexError("Somente é possível comentar quando o chamado possui um responsável.")
} }

6
src/components/tickets/ticket-comments.rich.tsx
View file

@ -38,7 +38,9 @@ export function TicketComments({ ticket }: TicketCommentsProps) {
const canSeeInternalComments = normalizedRole === "admin" || normalizedRole === "agent" const canSeeInternalComments = normalizedRole === "admin" || normalizedRole === "agent"
const hasAssignee = Boolean(ticket.assignee) const hasAssignee = Boolean(ticket.assignee)
const isRequester = convexUserId ? ticket.requester.id === convexUserId : false const isRequester = convexUserId ? ticket.requester.id === convexUserId : false
const canStaffComment = hasAssignee // Gestor pode comentar sem responsável; admin/agent só com responsável
const isManager = normalizedRole === "manager"
const canStaffComment = hasAssignee || isManager
const canComment = isRequester || (isStaff && canStaffComment) const canComment = isRequester || (isStaff && canStaffComment)
const addComment = useMutation(api.tickets.addComment) const addComment = useMutation(api.tickets.addComment)
const removeAttachment = useMutation(api.tickets.removeCommentAttachment) const removeAttachment = useMutation(api.tickets.removeCommentAttachment)
@ -366,7 +368,7 @@ export function TicketComments({ ticket }: TicketCommentsProps) {
)} )}
{!canComment && ( {!canComment && (
<div className="rounded-xl border border-amber-200 bg-amber-50 px-3 py-2 text-sm text-amber-700"> <div className="rounded-xl border border-amber-200 bg-amber-50 px-3 py-2 text-sm text-amber-700">
Atribua um responsável ao chamado para que a equipe possa comentar. Atribua um responsável ao chamado para que a equipe técnica possa comentar.
</div> </div>
)} )}
<form onSubmit={handleSubmit} className="mt-4 space-y-3"> <form onSubmit={handleSubmit} className="mt-4 space-y-3">